Skip to content

Add favorites backup and faster general lookup - #51

Merged
vanities merged 1 commit into
masterfrom
codex/favorites-backup
Sep 27, 2026
Merged

vanities merged 1 commit into
masterfrom
codex/favorites-backup

Conversation

@vanities

@vanities vanities commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Adds Settings → Favorites Backup to export saved thread links and named generals as JSON, and import missing favorites while preserving existing names. Invalid files are rejected before any inserts; duplicate entries are skipped. Backups exclude media, settings, and reading progress.

Open Link now accepts board shortcuts such as /biz/. Named-general lookup filters catalog titles before parsing comments, avoiding rich-text work for unrelated threads.

Validation on iPhone Air / iOS 26.5: 79 unit tests passed, including SwiftData import, duplicate preservation, malformed backups, board shortcuts, and selective comment parsing. All 8 existing browsing UI tests passed together on rerun after an initial invalid-coordinate tab tap. The new backup UI test passed separately after correcting the native picker button label to Save, for 9 passing UI tests total. The backup screen and native Files picker were visually inspected. SwiftLint reports 16 existing warnings and no serious violations. GitHub CI remains in progress at merge time.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a8b7c46a-eaf3-46da-82f9-14bf0867ea82

📥 Commits

Reviewing files that changed from the base of the PR and between fd1b4ae and 6d6a6c6.

📒 Files selected for processing (13)
  • README.md
  • swiftchan.xcodeproj/project.pbxproj
  • swiftchan/Models/FavoritesBackup.swift
  • swiftchan/Services/DeepLinker.swift
  • swiftchan/Services/FavoritesBackupStore.swift
  • swiftchan/ViewModels/RecurringFavoriteViewModel.swift
  • swiftchan/Views/Boards/OpenLinkSheet.swift
  • swiftchan/Views/Favorites/FavoritesBackupView.swift
  • swiftchan/Views/SettingsView.swift
  • swiftchanTests/DeepLinkerTests.swift
  • swiftchanTests/FavoritesBackupTests.swift
  • swiftchanTests/RecurringFavoriteTests.swift
  • swiftchanUITests/BrowsingUITests.swift
 ______________________________________________________________________
< Stop swallowing exceptions. They don't become less real in the dark. >
 ----------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vanities
vanities merged commit 63308f7 into master Sep 27, 2026
1 of 2 checks passed
@vanities
vanities deleted the codex/favorites-backup branch September 27, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant