Repository navigation
Bookmark individual replies with saved text and backup support - #53
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posts now offer Save Reply in their options menu. Favorites → Saved Replies keeps a readable text snapshot with search, an exact post link, sharing, and removal. The saved text remains available after the thread expires; media is not downloaded.
Adds a board-scoped SavedReply model through a V2 → V3 migration. Favorites Backup includes reply snapshots and skips existing bookmarks during import. Backups containing replies use format version 2 so older app versions reject them instead of silently dropping replies; version 1 backups remain importable.
CI had two failures: an app screenshot timed out in the backup test and crashed the runner, and the general-edit test failed an immediate text assertion. Diagnostic attachments now capture XCUIScreen instead of querying app screenshot bounds, including the native Files picker. The edit regression uses a numeric marker and waits for its value, avoiding autocorrection-sensitive wording and immediate reads. The final field value was unavailable in the CI artifact; that change is test hardening rather than a confirmed diagnosis of the text-entry failure.
Validation on iPhone Air / iOS 26.5: 82 unit tests passed, including V1/V2 migration, persistence, backup round-trips, duplicate handling, and rejection before partial import. All 11 browsing UI tests passed together, including saving, reopening the exact post, removing a bookmark, and the revised general-edit test. The focused backup/export UI check also passed with the final screen-capture helper. Simulator screenshots reviewed. SwiftLint: 16 existing warnings, 0 serious violations. GitHub CI is pending.