Return the downloaded path from the deepcell-types download helpers - #10
Merged
Conversation
`download_deepcell_types_baseline` (added in this PR) returns the list of local paths, but `download_deepcell_types_model` / `_data` dropped `fetch_data`'s return value, so callers had no supported way to locate the file they just downloaded. deepcell-types' public `download_model()` / `download_training_data()` are documented to return a `pathlib.Path`; without this they must guess the filename by globbing `~/.deepcell`, which does not work for version keys that differ from the asset filename (e.g. `2026-06-23-ptft` -> `deepcell-types_2026-06-23_resmlp_ptft.pt`). Returning a value where `None` was returned before is backwards compatible. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sy8eiMVmmQHXRAccKwzAyz
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8.
download_deepcell_types_baseline(added in #8) returns the list of local paths, butdownload_deepcell_types_model/download_deepcell_types_datadiscardfetch_data's return value, so a caller has no supported way to locate the file it just downloaded.This matters for the deepcell-types side (vanvalenlab/deepcell-types#47): its public
download_model()/download_training_data()are documented to return apathlib.Path. Without a return value the adapter has to guess the filename by globbing~/.deepcell/models, which breaks for version keys that differ from the asset filename —2026-06-23-ptftmaps todeepcell-types_2026-06-23_resmlp_ptft.pt, so adeepcell-types_2026-06-23-ptft_*.ptglob finds nothing.Scoped to the two deepcell-types helpers, matching the shape
download_deepcell_types_baselinealready has. Returning a path whereNonewas returned before is backwards compatible;cellsam/torch-mesmerare left alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01Sy8eiMVmmQHXRAccKwzAyz