fix: disable missing Ironic log config cleanly - #4234
Open
Rico Lin (ricolin) wants to merge 1 commit into
Open
Conversation
Render an empty log_config_append value instead of YAML null so Helm does not serialize the literal <no value> filename into ironic.conf. Assisted-By: Codex <noreply@openai.com> Change-Id: I58b533d2d434ed65227f5eafae6a0e340e0a8370 Signed-off-by: Rico Lin <rlin@vexxhost.com>
Rico Lin (ricolin)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Production compatibility fix. No emulation, credentials, or environment-specific data is included.
Summary
log_config_appendas an empty value instead of YAMLnull<no value>filename intoironic.confValidation
go test ./roles/ironic/...helm lint charts/ironiclog_config_appendas disabled