fix(ipmi-exporter): create deployment namespace - #4246
fix(ipmi-exporter): create deployment namespace#4246Tadas Sutkaitis (fitbeard) wants to merge 3 commits into
Conversation
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f1c89418
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| --- | ||
| fixes: | ||
| - | | ||
| The IPMI exporter role now creates the ``monitoring`` namespace before\n deploying its resources. |
There was a problem hiding this comment.
Replace the literal newline escape in the release note
When Reno/Sphinx renders this note, the literal \n embedded in the YAML block cannot create a line break and instead produces malformed text around “before…deploying.” Replace it with an actual newline or ordinary whitespace so the published release notes remain readable.
AGENTS.md reference: AGENTS.md:L20-L20
Useful? React with 👍 / 👎.
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
What changed
monitoringnamespace before deploying IPMI exporter resources;Why
The role assumed monitoring infrastructure had already created the namespace. A focused IPMI exporter deployment therefore failed on a fresh cluster.
This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.
Validation
git diff --checkpassed;galaxy[no-changelog]metadata issue;