Skip to content

fix(ipmi-exporter): create deployment namespace - #4246

Open
Tadas Sutkaitis (fitbeard) wants to merge 3 commits into
mainfrom
agent/ipmi-exporter-create-namespace
Open

fix(ipmi-exporter): create deployment namespace#4246
Tadas Sutkaitis (fitbeard) wants to merge 3 commits into
mainfrom
agent/ipmi-exporter-create-namespace

Conversation

@fitbeard

Copy link
Copy Markdown
Contributor

What changed

  • create the monitoring namespace before deploying IPMI exporter resources;
  • add a release note.

Why

The role assumed monitoring infrastructure had already created the namespace. A focused IPMI exporter deployment therefore failed on a fresh cluster.

This production fix is extracted from #4152 so it can be reviewed, released, and backported independently from selective CI.

Validation

  • file-scoped pre-commit hooks passed;
  • git diff --check passed;
  • the repository-wide Ansible lint traversal reached all roles and only failed on the existing galaxy[no-changelog] metadata issue;
  • Reno parsed the new note and only reported the repository's existing duplicate release-note UID.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7f1c89418

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

---
fixes:
- |
The IPMI exporter role now creates the ``monitoring`` namespace before\n deploying its resources.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Replace the literal newline escape in the release note

When Reno/Sphinx renders this note, the literal \n embedded in the YAML block cannot create a line break and instead produces malformed text around “before…deploying.” Replace it with an actual newline or ordinary whitespace so the published release notes remain readable.

AGENTS.md reference: AGENTS.md:L20-L20

Useful? React with 👍 / 👎.

Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
Signed-off-by: Mohammed Naser <mnaser@vexxhost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants