Skip to content

docs: link the upstream libtailscale conn-cleanup fix #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesyong-42 merged 1 commit into from
Oct 25, 2026
Merged

docs: link the upstream libtailscale conn-cleanup fix #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apple/Vendor/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ versions embedded in the resulting framework binaries.
connections in a test). The Go-owned descriptor stays open until cleanup, so
its number cannot be reused while the connection is alive. `newConn` returns
the C descriptor so the added `TestConnCleanupAfterFDReuse` can drive it; the
test fails without the fix. The same change has been prepared for upstream;
drop this patch once upstream includes it.
test fails without the fix. The same change is proposed upstream in
[tailscale/libtailscale#69](https://github.com/tailscale/libtailscale/pull/69)
(issue [tailscale/tailscale#21934](https://github.com/tailscale/tailscale/issues/21934));
drop this patch once it lands.

Upstream's framed fd-passing records (`4e3b222`, `258321b9f`) replaced
truffle's earlier remote-address patch: each connection's remote address
Expand Down
4 changes: 3 additions & 1 deletion docs/tailscale-upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ typed-DERP-ID test patch is upstream. Upstream still keys connection cleanup by
the C-side descriptor, whose number is reused almost immediately: in a test,
7 of 8 accepted connections never had their `net.Conn` closed. The new
`libtailscale-conn-cleanup.patch` keys cleanup by the Go-owned descriptor and
adds a regression test that fails without it. The peer-notification and
adds a regression test that fails without it. The same change is proposed
upstream in [tailscale/libtailscale#69](https://github.com/tailscale/libtailscale/pull/69)
(issue [tailscale/tailscale#21934](https://github.com/tailscale/tailscale/issues/21934)). The peer-notification and
IPN-stream-recovery patches are unchanged. See
[the provenance record](../apple/Vendor/README.md).

Expand Down
Loading