Repository navigation
chore(deps): move the napi crates together (napi 3.15.0, napi-derive 3.6.13) - #235
Merged
Merged
Conversation
…3.6.13) The napi crates are released as one family, and napi-derive's `#[napi]` expansion targets its own napi and napi-derive-backend. Dependabot bumps them one at a time, so #204 (napi 3.8.5 -> 3.8.6 alone) has been red at CI `check` Build on every rebase since 2026-10-12. - napi 3.8.6 depends on ctor 0.11 with no features (3.8.5 asked ctor 0.10 for `proc_macro`), and napi-derive 3.5.4 expands to `ctor::ctor`. - `cargo check -p truffle-napi`, measured on main 053c473: napi 3.8.6 alone: 26 errors (E0433, cannot find `ctor` in `ctor`); + napi-derive 3.5.5: 86 errors (napi-derive-backend floats to 5.1.2 and wants prelude functions napi 3.8 lacks); the family together: 0 errors, no source change. - Lock only: napi 3.15.0, napi-derive 3.6.13, napi-derive-backend 6.1.6, napi-sys 3.4.1, napi-build 2.6.0; with them ctor 1.0.13 and convert_case 0.12.0, and ctor-proc-macro, dtor and dtor-proc-macro leave. - dependabot.yml groups `napi` and `napi-*` for cargo, so the family arrives as one PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The napi crates are released as one family, and
napi-derive's#[napi]expansion targets its ownnapiandnapi-derive-backend. Dependabot bumps them one at a time, so #204 (napi 3.8.5 → 3.8.6 alone) has been red at CIcheckBuild on every rebase since 2026-10-12. This PR moves the family together, in the lockfile only, and groups it independabot.ymlso the next bump arrives as one PR. It supersedes #204.Why #204 is red
ctor0.11 with default features off and no features. napi 3.8.5 askedctor0.10 forproc_macro.napi-derive3.5.4 expands#[napi]toctor::ctor, which is now configured out.Measured (
cargo check -p truffle-napion main 053c473, 2026-10-27)error[E0433]: cannot find ctor in ctornapi-derive-backendfloats to 5.1.2, whose output calls prelude functions napi 3.8 lacks (get_named_property_raw,from_raw_required_field, …)The lock change
With them,
ctormoves 0.10.0 → 1.0.13 andconvert_case0.11.0 → 0.12.0.ctor-proc-macro,dtoranddtor-proc-macroleave the lock. NoCargo.tomlchanges: the workspace already asks fornapi = "3"andnapi-derive = "3".dependabot.yml
The cargo entry gains
groups: napi: patterns: ['napi', 'napi-*'].Tests
Run locally on this branch (88347c3, macOS arm64, pnpm 10.20.0, node 26) on 2026-10-27, as CI
checkruns them. Every step exited 0:pnpm install --frozen-lockfile --ignore-scriptspnpm run release:check,pnpm run lint,pnpm run format:checkpnpm run build:napi build --platform --releasecompiled napi 3.15.0, napi-derive 3.6.13, napi-derive-backend 6.1.6, napi-sys 3.4.1 and ctor 1.0.13 into truffle-napi (47.7 s), and the other five packages built.pnpm run test: benchmark/app 312/312, plus packages/core and packages/react.cargo metadata --lockedcargo deny check(0.20.2): advisories ok, bans ok, licenses ok, sources okThe build rewrote the tracked
crates/truffle-napi/index.d.ts, and it came out byte-identical: the newnapi-deriveemits the same type definitions.The pinned
@napi-rs/cli3.6.2 builds the new family, so this PR does not move it.cargo clippy -p truffle-napi -- -D warningsis red, with the same four errors onmain's lock: threeunsafe_codeand onenew_without_default, all in truffle-napi's own source. CI's clippy excludes truffle-napi, and this PR does not change that.Open
Why Dependabot proposes napi 3.8.6 rather than 3.15.0 is unexplained. It is not the MSRV: every version involved declares 1.88.
The Dependabot integration red (not this PR)
#204's Integration job failed for a separate reason: the Dependabot copy of
TRUFFLE_TEST_AUTHKEYhad been stale since the Actions secret was rotated on 2026-10-20. Every Dependabot integration run was red from 2026-10-20 22:00Z, waiting out authentication. The Dependabot copy was reset on 2026-10-27 at 17:05Z. This PR's own Integration run reads the Actions secret.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.