Repository navigation
build(napi): sync package-lock.json with @napi-rs/cli 3.10.9 - #246
Merged
Merged
Conversation
#242 bumped @napi-rs/cli 3.6.2 -> 3.10.9 in crates/truffle-napi/package.json and regenerated pnpm-lock.yaml, but not the standalone npm lockfile that the NAPI Build workflow installs with `npm ci`. The 0.7.25 release's NAPI Build failed on every target ("lock file's @napi-rs/cli@3.6.2 does not satisfy @napi-rs/cli@3.10.9"), so @vibecook/truffle-native@0.7.25 was never published and the npm publish timed out waiting for it. Regenerated with `npm install --package-lock-only --ignore-scripts`; `npm ci` now installs @napi-rs/cli 3.10.9, and check-release-versions passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JZwaBuXD1phVAJsq2NMXu5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 0.7.25 release failed at NAPI Build:
npm ciincrates/truffle-napirejected the lockfile on all 5 targets (lock file's @napi-rs/cli@3.6.2 does not satisfy @napi-rs/cli@3.10.9). #242 bumped@napi-rs/cliinpackage.jsonandpnpm-lock.yamlbut not in this standalone npm lockfile. Nothing other than the release's NAPI Build runsnpm cithere, so CI never caught it. Because@vibecook/truffle-native@0.7.25was never published, the npm publish timed out and Release Please failed.This regenerates the lockfile with
npm install --package-lock-only --ignore-scripts.It's titled
build:on purpose so release-please doesn't cut 0.7.26. After it merges,truffle-v0.7.25moves to the merge commit and the NAPI build and npm publish re-run for 0.7.25. Compared with the original tag commit0967a8b, the only changes are this lockfile and the sidecar checksums already pinned on main by7d9a11b. There are no source changes, so the crates.io 0.7.25 crates and the release binaries stay consistent.Type of Change
Checklist
npm ciincrates/truffle-napiinstalls@napi-rs/cli3.10.9, andnode scripts/sync-release-locks.mjs --checkandnode scripts/check-release-versions.mjs --allow-missing-checksumspasscargo test/cargo clippy/cargo fmt --check: no Rust changesAdditional Context
Follow-up worth doing separately: add an
npm ci --dry-runcheck forcrates/truffle-napito CI, so this kind of drift fails on the PR instead of at release time.Generated by Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.