Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: vitali87/code-graph-rag/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
||
| try: | ||
| report = move( | ||
| Path(self.project_root), |
There was a problem hiding this comment.
If project selects a known project indexed from another repository, this handler still passes self.project_root to move. The move operation resolves the selected graph's relative paths under the server-local root, so a non-dry-run request can modify unrelated local files that share those paths. Resolve and validate the selected project's stored source root before invoking move, as the rename and change-signature handlers already do.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical project-root scoping issue and a moderate dry-run contract mismatch remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Exposes the move refactoring operation through MCP, including schema metadata, descriptions, registration, and contract re-ingestion.
Changes:
- Registers the MCP move tool and handler.
- Adds move parameters and user-facing descriptions.
- Connects execution to contract-aware re-ingestion.
Review findings:
- Critical (3 votes):
mcp/tools.pymust validate the selected project's root before moving files. - Moderate (1 vote): The dry-run description promises a diff that the move planner does not currently provide.
| File | Summary |
|---|---|
codebase_rag/tools/tool_descriptions.py |
Adds move tool and parameter descriptions. |
codebase_rag/mcp/tools.py |
Registers and executes the MCP move operation with contract re-ingestion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| try: | ||
| report = move( | ||
| Path(self.project_root), | ||
| self.ingestor.fetch_all, | ||
| project_name, | ||
| qualified_name, | ||
| target_module, |
|
Closing as superseded: this is part of the split of #1549, which was closed without merging, and it targets the stale Generated by Claude Code |

Register the MCP move tool, schema, descriptions, and contract re-ingest path.
Files changed
codebase_rag/mcp/tools.pycodebase_rag/tools/tool_descriptions.pyDiff stats
+105 additions, -1 deletions (106 LOC)
Dependencies
This PR depends on:
pr-6Dependency graph
Merge in this order: