Skip to content

feat(signature): contract expectation, shared call-site helpers and constants for change_signature (#1533, 1/9) - #2157

Closed
vitali87 wants to merge 1 commit into
mainfrom
pr-split/split-1912-change-signature/pr-1
Closed

vitali87 wants to merge 1 commit into
mainfrom
pr-split/split-1912-change-signature/pr-1

Conversation

@vitali87

Copy link
Copy Markdown
Owner

Part 1 of the #1912 split (issue #1533). Adds change_signature_expectation to the postcondition contract along with its tests, moves the call-site helpers rename already had into editing/sites.py so change_signature can share them, and adds the change_signature message and key constants. Nothing calls change_signature yet.

Files changed

  • codebase_rag/constants/ast_python.py
  • codebase_rag/constants/cli.py
  • codebase_rag/constants/core.py
  • codebase_rag/constants/graph.py
  • codebase_rag/editing/__init__.py
  • codebase_rag/editing/contract.py
  • codebase_rag/tests/test_edit_contract.py
  • codebase_rag/editing/sites.py
  • codebase_rag/editing/rename.py

Diff stats

+286 additions, -71 deletions (357 LOC)

Dependency graph

Merge in this order:

pr-1: feat(signature): contract expectation, shared call-site helpers and constants for change_signature (#1533, 1/9)  <-- this PR
└── pr-2: feat(signature): parameter specs, mapping sources and the change_signature contract check (#1533, 2/9)
    └── pr-3: feat(signature): read the header, bind call arguments, render the rewrite (#1533, 3/9)
        └── pr-4: feat(signature): the change_signature operation (#1533, 4/9)
            └── pr-5: feat(signature): expose change_signature through the CLI and MCP, with docs (#1533, 5/9)
                └── pr-6: test(signature): acceptance, transaction and MCP tests for change_signature (#1533, 6/9)
                    └── pr-7: test(signature): mapping tests for change_signature (#1533, 7/9)
                        └── pr-8: test(signature): definition and renamed-parameter tests for change_signature (#1533, 8/9)
                            └── pr-9: test(signature): hierarchy, receiver and default guards for change_signature (#1533, 9/9)

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: vitali87/code-graph-rag/.coderabbit.yaml

Review profile: QUIET

Plan: Advanced

Run ID: 0f72d334-bd8b-4a9d-85f0-bbeb4813859c

📥 Commits

Reviewing files that changed from the base of the PR and between 9ca0208 and a37349e.

📒 Files selected for processing (9)
  • codebase_rag/constants/ast_python.py
  • codebase_rag/constants/cli.py
  • codebase_rag/constants/core.py
  • codebase_rag/constants/graph.py
  • codebase_rag/editing/__init__.py
  • codebase_rag/editing/contract.py
  • codebase_rag/editing/rename.py
  • codebase_rag/editing/sites.py
  • codebase_rag/tests/test_edit_contract.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vitali87 vitali87 closed this Sep 22, 2026
@vitali87
vitali87 deleted the pr-split/split-1912-change-signature/pr-1 branch September 22, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant