Repository navigation
test(graph-rs): add the bulk writer and walk fuzz target - #3444
Conversation
This comment has been minimized.
This comment has been minimized.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Generate and model graph batches rust/cgr_graph_rs/fuzz/fuzz_targets/sqlite_graph.rs |
The target generates node and relationship batches, models expected outcomes, and updates its model when operations succeed. It checks model state after each operation. |
Check persisted graph state rust/cgr_graph_rs/fuzz/fuzz_targets/sqlite_graph.rs |
The target compares ordered database rows, properties, merge keys, graph version, and loaded graph ordering and adjacency with the model. |
Check walk results rust/cgr_graph_rs/fuzz/fuzz_targets/sqlite_graph.rs |
The target checks seed parsing and rendering, bounded walk rows and paths, JSON output, and modeled traversal order. |
Priority:
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Other
Suggested reviewers: claude
Merge Risk: 
Minimal · previous review afc7b
-
No concrete issue remains that would prevent merging this fuzz target after normal checks.
Pre-merge checks: 
4
-
Full details: Description check
-
Explanation
The description is mostly complete. It includes the summary, demo statement, change type, related issues, detailed test plan, changed files, dependencies, and dependency order. The template checklist is omitted, but the main required change and validation information are present.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] Appears safe to merge as part of the stack, with PR #3445 providing the fuzz package manifest. SummaryAdds
Reviews (1) · Last reviewed commit: "test(graph-rs): add the bulk writer and ..." · Reviewed by Greptile |
189c431 to
2869e6d
Compare
|
The job's first Update: once the backlog cleared, I re-ran the failed job once at 20:02 UTC and it passed (attempt 2). CI, Rust Wheels and every other check on 2869e6d are green. Generated by Claude Code |
2869e6d to
e23ecc6
Compare
|



Summary
sqlite_graphruns a program of node batches, relationship batches and walks on an in-memory database with the engine's schema (EG_SCHEMA_SQL), and keeps a model of the graph.merge_nodesandmerge_relationshipsleave the database equal to the model after every batch. They fail exactly when the model says they do (malformed property JSON, a SET that moves a node onto another node's key), and a failed batch changes nothing. The relationship count is the number of distinct matched row indexes.walkreturns the recursive CTE's rows in its order, as the walk module documents them.pathandto_jsonagree with those rows.parse_seedsreads backjson_group_array's rendering.Graph::loadreads the model's graph.Demo
No user-visible change: fuzz targets only. Nothing in the package, CI or the wheel builds
rust/cgr_graph_rs/fuzz.Type of Change
Related Issues
None.
Test plan
Run on the whole stack, since the package builds once its manifest lands in the last PR:
cargo fuzz coverage).cargo +nightly-2025-07-16 check --binspasses, as well as the current nightly.Files changed
rust/cgr_graph_rs/fuzz/fuzz_targets/sqlite_graph.rsDiff stats
+710 additions, -0 deletions (710 LOC)
Dependencies
This PR depends on:
pr-2Dependency graph
Merge in this order:
Summary by CodeRabbit