Skip to content

fix: escape plan text in the status table, merge summaries and error echoes - #131

Closed
vitali87 wants to merge 2 commits into
fix/escape-plan-text-in-rich-outputfrom
fix/escape-status-and-summaries
Closed

vitali87 wants to merge 2 commits into
fix/escape-plan-text-in-rich-outputfrom
fix/escape-status-and-summaries

Conversation

@vitali87

Copy link
Copy Markdown
Owner

Summary

Third and last escaping follow-up (after #124 and #127): the status table row (id, title, branch), the merge summary lines (Merged (…), Skipped (…), Failed (…)), strict LOC-bound warnings, Edited plan is invalid: …, the generic [red]{exc}[/red] echoes, the editor's "Source and destination are the same ('…')" message and the Groups [...] are empty after editing message now all go through rich.markup.escape, so bracketed plan text is printed rather than swallowed as a Rich style tag.

Stacked on #127 (fix/escape-plan-text-in-rich-output).

Test plan

  • TestRichEscapingOfStatusAndSummaries, TestRichEscapingOfMergeSummary (a merge run with [pr-1] merged, [pr-2] skipped as draft, [pr-3] failed), TestRichEscapingOfEmptyGroupsError — all five new tests fail on the base
  • 453 tests pass, ruff clean
  • Local review: 5/5

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5ff9e57b-0168-4099-bf85-c0561eed94cf

📥 Commits

Reviewing files that changed from the base of the PR and between 069a82d and 64a0751.

📒 Files selected for processing (2)
  • pr_split/cli.py
  • tests/test_cli_coverage.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…-status-and-summaries

Drops the empty-groups message escaping and its test: main now drops
emptied groups instead of printing their ids. The status table and
merge summary (including main's new 'blocked' line) stay escaped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w

Copy link
Copy Markdown
Owner Author

This change is already in main: it landed via the merge train #243, which includes this PR's head commit. GitHub can't mark a stacked PR merged when it lands that way, so I'm closing it as done.


Generated by Claude Code

@vitali87 vitali87 closed this Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants