Repository navigation
fix: keep score comment table rows intact for bracketed dependency ids and multi-line titles - #148
Merged
2 commits merged intoSep 27, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
…s and multi-line titles
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small gaps in the GitHub Action's comment table (
scripts/score_pr.py):Depends Oncolumn was not escaped, so a dependency id containing|broke that row while the same id was escaped in its own row_md_escapedid not neutralise newlines, so a multi-line LLM title ended the table earlyMIN_LOCwas passed straight topr-split --min-locwithout the integer validationMAX_LOC/THRESHOLD_GROUPSget, soMIN_LOC=abcsurfaced as the generic "pr-split failed to generate a plan"Now every dependency is escaped,
_md_escapecollapses lines, and a non-emptyMIN_LOCis validated with the same clear error.Test plan
tests/test_score_pr_table.py: unit escape test; amain()run with a plan whose id/title contain|/newlines asserts both rows keep exactly six unescaped separators;MIN_LOC=abcexits with the integer error before any git call — all three fail on main