Skip to content

fix: keep score comment table rows intact for bracketed dependency ids and multi-line titles - #148

Merged
2 commits merged into
mainfrom
fix/score-pr-table-escaping
Sep 27, 2026
Merged

2 commits merged into
mainfrom
fix/score-pr-table-escaping

Conversation

@vitali87

Copy link
Copy Markdown
Owner

Summary

Three small gaps in the GitHub Action's comment table (scripts/score_pr.py):

  • the Depends On column was not escaped, so a dependency id containing | broke that row while the same id was escaped in its own row
  • _md_escape did not neutralise newlines, so a multi-line LLM title ended the table early
  • MIN_LOC was passed straight to pr-split --min-loc without the integer validation MAX_LOC/THRESHOLD_GROUPS get, so MIN_LOC=abc surfaced as the generic "pr-split failed to generate a plan"

Now every dependency is escaped, _md_escape collapses lines, and a non-empty MIN_LOC is validated with the same clear error.

Test plan

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f143cd8e-a283-41ee-b300-1b82d38163e4

📥 Commits

Reviewing files that changed from the base of the PR and between 671a081 and d859955.

📒 Files selected for processing (2)
  • scripts/score_pr.py
  • tests/test_score_pr_table.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
@vitali87 vitali87 closed this pull request by merging all changes into main in 8ca9e3b Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants