Repository navigation
fix: check gh authentication for the target host only - #170
Merged
2 commits merged intoSep 27, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
|
Warning Review limit reachedNext included review available in 53 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_gh_authran a baregh auth status, which exits 0 if any configured host is authenticated and 1 if any is broken. Two real failure modes:ghe.example.com, authenticated there, nothing for github.com) was told to rungh auth logineven though everyghcall pr-split makes would succeedThe check now targets the host pr-split actually talks to:
gh auth status --hostname <host>, where the host is$GH_HOSTif set, else parsed from theoriginremote URL (https/ssh/git/git+ssh and scp-likeuser@host:path, ports and userinfo stripped, lowercased to match gh's case-sensitive--hostname), elsegithub.com. Single-label GHE hosts (git@ghe:org/repo) resolve correctly; local-path andfile://remotes fall back togithub.com.Test plan
GH_HOSToverride short-circuiting git,--hostnamepassed to gh, unauthenticated → False; 15 of 16 fail on maingh auth status --hostnamecase-sensitivity and GHE-only hosts.yml configs across four passes