Repository navigation
Conversation
…bbreviated commit
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…before-rev-parse Brings in the base PR (#136) as already updated with origin/main, so this stacked PR is current with main and shares its base's conflict resolution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015rnEEjXWDBdePRhKMmZr1w
|
This change is already in Generated by Claude Code |
Summary
split 1006could silently split the wrong thing: the argument-form decision consultedbranch_exists()(git rev-parse --verify) before_is_fork_ref(), and rev-parse happily resolves1006as an abbreviated commit SHA if any commit hash starts with those digits. The run then proceeded with "Extracting diff between main and 1006" against an arbitrary commit instead of fetching PR #1006 — reproduced against a real repo during review._is_fork_refnow wins unconditionally: a bare number (with or without#) is always a PR number. The precedence is documented in the argument help and README, including the escape hatch for a local branch literally named like a number — pass its full ref (refs/heads/1006), which flows throughbranch_exists/rev-parse and the whole pipeline (verified end to end, including the derived sub-branch namespace).Stacked on #136 (stack = #111→#136→this).
Test plan
test_pr_number_is_never_taken_for_an_abbreviated_sha— fails on the base (_resolve_fork_refnever called there)test_full_ref_is_not_a_fork_refandtest_full_ref_escape_hatch_takes_the_branch_pathpin the documented escape hatch1006) and verified the escape hatch on real git