[vitali87]

Problem

A mode-only change (chmod +x run.sh) shows up in the diff as

diff --git a/run.sh b/run.sh
old mode 100644
new mode 100755

with zero hunks. The planner has nothing to assign, validate_coverage passes (no hunks means no gap), and the mode change is absent from every sub-PR — the same silent-drop failure mode #61 fixed for binary files. (Pure renames used to hit this too; #49's --no-renames turns them into delete+add with hunks, so they are handled.)

Fix

validate_no_binary_files also rejects hunk-less entries with HUNKLESS_FILES_UNSUPPORTED: Diff contains files with no text hunks (mode-only or empty changes), which cannot be assigned to a sub-PR: run.sh. Commit them separately and re-run. Because it lives in the same check it is enforced everywhere #61 enforces it: split before planning, validate_plan, and execute on a saved plan.

Applying mode changes in the worktree is the real feature (read new mode from the header and chmod in the group's worktree); this PR makes the drop loud rather than silent.

Tests

Mode-only entry alongside a text file: the validator raises with the path; validate_plan rejects even when the text hunks are fully covered. 450 tests pass, ruff clean.

Stacked on #61 (fix/reject-binary-files).

[coderabbitai]

Warning

Review limit reached

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a9085040-58cc-4078-b1b9-75cb9c12e773

📥 Commits

Reviewing files that changed from the base of the PR and between 671a081 and 2bba5bd.

📒 Files selected for processing (3)

• pr_split/exceptions.py
• pr_split/planner/validator.py
• tests/test_validator.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}