Skip to content

fix(optimizer): preserve explicit asset queries in dependencies (fix #20285) - #23962

Open
Arham-Begani wants to merge 2 commits into
vitejs:mainfrom
Arham-Begani:fix/optimized-json-url
Open

Arham-Begani wants to merge 2 commits into
vitejs:mainfrom
Arham-Begani:fix/optimized-json-url

Conversation

@Arham-Begani

@Arham-Begani Arham-Begani commented Nov 1, 2026 •

Copy link
Copy Markdown

Imports such as data.json?url should return a URL; data.json?raw should return the file’s text. The dependency optimizer mishandled those suffixes. Tests cover both ES modules and CommonJS. 36 related tests pass, alongside build, type, lint and formatting checks.

I used an AI assistant while writing this and reviewed every change.

@Arham-Begani

Copy link
Copy Markdown
Author

Could a maintainer please rerun the failed Windows CI job? One bundled-dev HMR test timed out waiting for /hot updated/; the other platform jobs and the new regression tests passed. I don’t have permission to rerun it. Thanks!

@Arham-Begani

Copy link
Copy Markdown
Author

Description cleaned up. The only failing job is the Windows bundled-dev HMR timeout, which this change doesn't touch; could a maintainer rerun it?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant