Repository navigation
fix(optimizer): preserve explicit asset queries in dependencies (fix #20285) - #23962
Open
Arham-Begani wants to merge 2 commits into
Open
Arham-Begani wants to merge 2 commits into
Arham-Begani wants to merge 2 commits into
Conversation
Author
|
Could a maintainer please rerun the failed Windows CI job? One bundled-dev HMR test timed out waiting for /hot updated/; the other platform jobs and the new regression tests passed. I don’t have permission to rerun it. Thanks! |
Author
|
Description cleaned up. The only failing job is the Windows bundled-dev HMR timeout, which this change doesn't touch; could a maintainer rerun it? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports such as data.json?url should return a URL; data.json?raw should return the file’s text. The dependency optimizer mishandled those suffixes. Tests cover both ES modules and CommonJS. 36 related tests pass, alongside build, type, lint and formatting checks.
I used an AI assistant while writing this and reviewed every change.