Repository navigation
Conversation
DevEnvironment
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevEnvironment.close()rejects with<name> environment.pluginContainer called before initializedifinit()failed or never ran. ThepluginContainergetter throws whileclose()builds the array forPromise.allSettled, sodepsOptimizer?.close()andhot.close()never run either.Since #24020,
createServer()hits this on startup failure.initEnvironmentsadds each environment toserver.environmentsbefore awaitingenvironment.init(). Wheninit()rejects,server.close()callsclose()on that environment,Promise.allSettledswallows the rejection, and the transport stays open. I hit this directly in a CLI that creates an SSR environment withcreateEnvironment()and cleans up wheninit()fails. Because_initiatedis already set,init()can't be retried andclose()is the only cleanup path left.This changes
close()to callthis._pluginContainer?.close(), matchingBundledDev.close()which already guardsthis._devEngine?.close(). Initialized environments behave as before. #24167 proposed this guard along with waiting on in-flightinit()calls before a bot closed it without review. I left out that wait and didn't reset_initiatedon rejection soinit()behavior stays unchanged, though I can add either if you prefer.The new test in
hooks.spec.tsfails onmainand passes here. Standalone repro against 8.3.8 andmain, run withpnpm install && pnpm verify: https://github.com/onmax/repros/tree/repro/vite-devenvironment-close-before-init/vite-devenvironment-close-before-initPrepared with AI assistance for the repro and test. I checked the
DevEnvironment.close()andinitEnvironmentspaths myself and kept the fix to this guard.