Skip to content

Login page centered (#108) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oceandek merged 1 commit into from
Oct 29, 2026
Merged

Login page centered (#108) #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,18 @@ Numbers like #24 are GitHub issues or pull requests on [vives-project-xp/Project

Newest first. Each request has the same four parts: **Before**, **Asked**, **Changed**, **Where**.

### R14. Login page centered (2026-10-29, #108, PR #109)

**Before.** The login page's title, subtitle and **Log in** card stood against the left edge of the page, with empty space on the right.

**Asked.** *"verander de loginpagina ook aub, het staat links en niet in het midden, niet netjes"*.

**Changed.**
- The title, the subtitle and the **Log in** card (and the **Test login** card while it is on) are centered on the page, with some room above them.
- The **Log in** button fills the width of the card.

**Where.** `frontend/src/pmp_frontend/pages.py` (login page).

### R13. Tables fit the screen (2026-10-22, #89, PR #90)

**Before.** Page content was at most 896 px wide, and table cells never wrapped. The **Users** table (Name, Email, GitHub, Role, Programme, Year, Status) was wider than that, so on a laptop you had to **scroll to the right** to see Year and Status.
Expand Down Expand Up @@ -245,6 +257,7 @@ Newest first. "Live" means deployed to the VIVES VM by the Deploy workflow. "Mig
| New | **Chat reactions and @mentions:** 👍 ❤️ 😂 😮 😢 🎉 on any message (count, names on hover, click to take yours back); typing @ suggests the chat people and @team; a mentioned person sees the message highlighted and a red @ marker on the Chat item and the Chats screen until read; staff who only read along can't be mentioned; live in open chats; links in messages are now underlined; migration `0018` | #96 | #105 |
| New | **Chat: "is typing…", "Seen by" and search:** "Anna is typing…" for 5 s after the last keystroke (kept in the backend's memory); "Seen by N" on your own messages with the names on click (chat people only), updating live; search a chat's text and file names with From and Files only, a result scrolls to its message; open chats now poll `GET .../chat/updates` | #97 | #106 |
| New | **Chat lifecycle:** an Archived Project's chat is read-only and only Teachers and the Superuser read it, with "This chat will be deleted on <date>"; a daily background job deletes the messages and files 6 months after archiving; restoring before then keeps the history; deleting a User keeps their messages as "Deleted user"; migration `0019` (`projects.archived_at`, set to the migration day for Projects already archived). **Spec #91 complete.** | #98 | #107 |
| Changed | Login page centered, full-width Log in button (R14) | #108 | #109 |

### 2026-10-22: Project chat (spec #91)

Expand Down
10 changes: 6 additions & 4 deletions frontend/src/pmp_frontend/pages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ async def submit_dev_login() -> None:

dev_users = await api.dev_login_users()

with frame("Log in"):
ui.label("Project Management Platform").classes("text-h4")
ui.label("VIVES Project Experience").classes("text-subtitle1")
# Everything centered on the page (#108).
with frame("Log in"), ui.column().classes("w-full items-center gap-6 pt-8"):
with ui.column().classes("items-center gap-1 text-center"):
ui.label("Project Management Platform").classes("text-h4")
ui.label("VIVES Project Experience").classes("text-subtitle1")
with ui.card().classes("w-full max-w-md"):
ui.label("Log in").classes("text-h6")
if expired:
Expand All @@ -103,7 +105,7 @@ async def submit_dev_login() -> None:
.on("keydown.enter", submit)
)
error_message = ErrorMessage()
ui.button("Log in", on_click=submit).mark("log-in")
ui.button("Log in", on_click=submit).classes("w-full").mark("log-in")
if dev_users:
with ui.card().classes("w-full max-w-md"):
ui.label("Test login").classes("text-h6")
Expand Down
Loading