Repository navigation
Link the MR in Slack notifications, publish Docker on release - #22
Merged
Merged
Conversation
- Add Project.MergeRequestLink: GitLab MR or GitHub PR URL and label from the review's external ID, empty unless it is a positive number - Show the MR link after the project tag so readers reach the MR in one click; the title still opens the review - Fix mrkdwn escaping: "&", "<" and ">" in the project, title, author or branches broke the review link - Cover link building, message text and notifySlack wiring with tests - Update the message format in docs/llm/Slack.md
- Fix Docker publishing: a release created by GoReleaser with GITHUB_TOKEN never triggered docker.yml, so images needed a manual dispatch - Call docker.yml from go.yml after the release job, so images are built only for tags that passed tests and GoReleaser - Tag release images as latest too; manual rebuilds keep latest as is
sergeyfast
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack review notifications now link the merge request, so readers reach the MR in one click instead of going through the reviewer UI. The title still opens the review.
MR link:
reviewer.Project.MergeRequestLinkbuilds<vcsURL>/-/merge_requests/<id>(MR !42) or, for github.com,<vcsURL>/pull/<id>(PR #42) from the review'sexternalId. No link unless the ID is a positive number and the project has a VCS URL, so the message is unchanged otherwise. Fusion reviews carry the external ID too.Escaping fix:
&,<,>in the project, title, author, branches and MR label are escaped for Slack mrkdwn; a>in an MR title used to break the review link.Docs: message format updated in
docs/llm/Slack.md.CI: Docker images are published by go.yml after GoReleaser (docker.yml as a reusable workflow). A release created with GITHUB_TOKEN never triggered
on: release, so every image needed a manual dispatch. Release images are taggedlatesttoo (it was stuck since April); manual rebuilds leavelatestalone.Test plan
make fmt lint testclean0/ non-numeric ID, no VCS URL) and message text (with / without MR, escaping)notifySlackwiring test through a webhook stub (fails when the MR link is not passed)