refactor: use JoinHostPort for vnc tcp dialing - #541
Merged
Conversation
github-actions
Bot
added
needs-review
tenthirtyam
force-pushed
the
refactor/optimize-vmx-encoding-buffer-writes
branch
from
August 13, 2026 12:41
384e598 to
ced1323
Compare
Write VMX entries directly into the output buffer instead of formatting an intermediate string first. This avoids unnecessary allocations while preserving the same encoded output. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
Replace manual `"%s:%d"` address formatting with `net.JoinHostPort` when dialing VNC. This ensures host/port strings are constructed correctly (including IPv6 hosts) and avoids malformed TCP target addresses. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
refactor/optimize-vmx-encoding-buffer-writes
branch
from
August 13, 2026 12:43
ced1323 to
9d404e5
Compare
|
This functionality has been released in v2.1.5 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace manual
"%s:%d"address formatting withnet.JoinHostPortwhen dialing VNC. This ensures host/port strings are constructed correctly (including IPv6 hosts) and avoids malformed TCP target addresses.Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information