Skip to content

zathura 2026 - #59111

Merged
lemmi merged 7 commits into
void-linux:masterfrom
dkwo:zathura2026
Aug 5, 2026
Merged

lemmi merged 7 commits into
void-linux:masterfrom
dkwo:zathura2026

Conversation

@dkwo

@dkwo dkwo commented Feb 24, 2026

Copy link
Copy Markdown
Contributor
  • I tested the changes in this PR: YES
  • I built this PR locally for my native architecture, (aarch64-glibc)

cc @lemmi

@dkwo
dkwo force-pushed the zathura2026 branch 3 times, most recently from 466e479 to dc10b1b Compare February 24, 2026 03:38
@dkwo dkwo mentioned this pull request Feb 24, 2026
1 task
@dogknowsnx

Copy link
Copy Markdown
Contributor

Regarding girara: Upstream moved Gtk+-specific parts to zathura

Regarding musl: #57776 (comment)

@fanyx

fanyx commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

can be rebased on master, meson fix is merged.

@dkwo

dkwo commented Feb 25, 2026

Copy link
Copy Markdown
Contributor Author

@dogknowsnx I believe girara soname was already taken care, and disabled seccomp on musl for now (issue upstream), since we already use landlock that should be fine. What do you think?
@fanyx Thanks, rebased.

@dogknowsnx

dogknowsnx commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

girara builds fine w/o gtk+3-devel last time I tried, should probably be moved to zathura's makedepends?

EDIT (post-thumbs-up):

disabled seccomp on musl for now

Some thoughts: Not entirely sure, but personally I'd still prefer (temporarily) disabling tests (waiting for fix by upstream) over switching off a built-in security measure, given that the zathura-sandbox binary still runs fine on a native musl system (can't test myself) despite the one failing weston-based test - again, we currently don't even run tests for weston itself.

@dkwo
dkwo force-pushed the zathura2026 branch 2 times, most recently from 25c9ea6 to b79cbb3 Compare February 26, 2026 04:02
@dkwo

dkwo commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

@dogknowsnx Sure, I can do that. Note that the musl fix has been merged upstream, so it will be in the next release, and also that the landlock snadbox (imho better) is always enabled.

@dogknowsnx

Copy link
Copy Markdown
Contributor

There don't seem to be any advantages of updating right now, imho. Personally I'm happy to keep using zathura-0.5.13_1 as long as the issues mentioned above aren't sorted out upstream.

@dkwo

dkwo commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

All issues are fixed for me with v2026.03.27

@lemmi

lemmi commented Mar 31, 2026

Copy link
Copy Markdown
Member

Alright. Thanks for keeping up. I'll try and have a look this week.

@Andrew-Elia

Copy link
Copy Markdown

I would love to see zathura updated soon to help with the issues of PDFs having different page sizes. pulls: pwmt/zathura#851 and pwmt/zathura#849 (some issues fixed: pwmt/zathura#724, and pwmt/zathura#447 Felipe-9's comment, the latter is the issue I am currently having.)

I really appreciate your work, Thanks a lot!

@dkwo

dkwo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

This happens on ci only, after update to gtk4:

6/12 xvfb_session     ERROR             0.60s   (exit status 134 or signal 6 SIGABRT)
>>> MESON_TEST_ITERATION=1 MALLOC_PERTURB_=130 GTK_A11Y=none UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 G_TEST_SRCDIR=/builddir/zathura-2026.07.02/tests G_TEST_BUILDDIR=/builddir/zathura-2026.07.02/build/tests ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 EGL_LOG_LEVEL=fatal LIBGL_DEBUG=quiet MESA_LOG=null NO_AT_BRIDGE=1 /usr/bin/xvfb-run -s '-screen 0 1400x900x24 -ac +extension GLX +render -noreset' -a tests/test_session

Comment thread srcpkgs/girara/template Outdated
Comment thread srcpkgs/girara/template Outdated
Comment thread srcpkgs/zathura/template Outdated
@dkwo

dkwo commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@sebastinas Thanks for taking a look! Is there a way in meson to skip a single test, which should not be run in ci?

@dkwo
dkwo force-pushed the zathura2026 branch 2 times, most recently from 48c51fe to fc77586 Compare July 4, 2026 07:56
@sebastinas

Copy link
Copy Markdown

If it's the tests running with xvfb that should be skipped, don't have xvfb installed. The tests requiring xvfb are skipped in this case.

@dkwo
dkwo force-pushed the zathura2026 branch 6 times, most recently from 80edf34 to ce17d33 Compare July 9, 2026 17:43
@dkwo
dkwo force-pushed the zathura2026 branch 2 times, most recently from 8da2be8 to 2ee566f Compare July 24, 2026 14:25
Comment thread srcpkgs/zathura/template Outdated
@dkwo

dkwo commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@lemmi This could be good to go.

@lemmi

lemmi commented Jul 28, 2026

Copy link
Copy Markdown
Member

@dkwo sure, can you just comment on the static linking thing of zathura-pdf-mupdf (it's not a real blocker, just want to know the rational for the change)

@dkwo

dkwo commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

if I do not link mupdf statically, I get a build failure on aarch64:

[12/12] Linking target libpdf-mupdf.so
FAILED: [code=1] libpdf-mupdf.so 
cc  -o libpdf-mupdf.so libpdf-mupdf.so.p/zathura-pdf-mupdf_document.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_image.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_attachment.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_index.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_links.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_page.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_plugin.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_render.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_search.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_select.c.o libpdf-mupdf.so.p/zathura-pdf-mupdf_utils.c.o -flto -Wl,--as-needed -Wl,--allow-shlib-undefined -shared -fPIC -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -fstack-clash-protection -D_FORTIFY_SOURCE=2 -march=armv8-a -O2 -pipe -mbranch-protection=standard -ffile-prefix-map=/builddir/zathura-pdf-mupdf-2026.07.18/build=. -Wl,-rpath,/usr/lib64 -Wl,--start-group /usr/lib64/libgirara.so /usr/lib64/libgio-2.0.so /usr/lib64/libgobject-2.0.so /usr/lib64/libglib-2.0.so /usr/lib64/libcairo.so /usr/lib/libmupdf.a -Wl,--end-group
/usr/bin/ld: /usr/lib/libmupdf.a(load-jpx.o): in function `jpx_read_image':
(.text.jpx_read_image+0x8c): undefined reference to `fz_opj_set_default_decoder_parameters'
/usr/bin/ld: (.text.jpx_read_image+0xa4): undefined reference to `fz_opj_create_decompress'
/usr/bin/ld: (.text.jpx_read_image+0xbc): undefined reference to `fz_opj_set_info_handler'
/usr/bin/ld: (.text.jpx_read_image+0xd0): undefined reference to `fz_opj_set_warning_handler'
/usr/bin/ld: (.text.jpx_read_image+0xe4): undefined reference to `fz_opj_set_error_handler'
/usr/bin/ld: (.text.jpx_read_image+0xf0): undefined reference to `fz_opj_setup_decoder'
/usr/bin/ld: (.text.jpx_read_image+0xfc): undefined reference to `fz_opj_stream_default_create'
/usr/bin/ld: (.text.jpx_read_image+0x114): undefined reference to `fz_opj_stream_set_read_function'
/usr/bin/ld: (.text.jpx_read_image+0x124): undefined reference to `fz_opj_stream_set_skip_function'
/usr/bin/ld: (.text.jpx_read_image+0x134): undefined reference to `fz_opj_stream_set_seek_function'
/usr/bin/ld: (.text.jpx_read_image+0x144): undefined reference to `fz_opj_stream_set_user_data'
/usr/bin/ld: (.text.jpx_read_image+0x150): undefined reference to `fz_opj_stream_set_user_data_length'
/usr/bin/ld: (.text.jpx_read_image+0x160): undefined reference to `fz_opj_read_header'
/usr/bin/ld: (.text.jpx_read_image+0x174): undefined reference to `fz_opj_stream_destroy'
/usr/bin/ld: (.text.jpx_read_image+0x17c): undefined reference to `fz_opj_destroy_codec'
/usr/bin/ld: (.text.jpx_read_image+0x280): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0x2d8): undefined reference to `fz_opj_decode'
/usr/bin/ld: (.text.jpx_read_image+0x2e4): undefined reference to `fz_opj_stream_destroy'
/usr/bin/ld: (.text.jpx_read_image+0x2ec): undefined reference to `fz_opj_destroy_codec'
/usr/bin/ld: (.text.jpx_read_image+0x2f4): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0x420): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0xc34): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0xcb8): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0xdc8): undefined reference to `fz_opj_image_destroy'
/usr/bin/ld: (.text.jpx_read_image+0xe24): undefined reference to `fz_opj_stream_destroy'
/usr/bin/ld: (.text.jpx_read_image+0xe2c): undefined reference to `fz_opj_destroy_codec'
/usr/bin/ld: (.text.jpx_read_image+0xe48): undefined reference to `fz_opj_destroy_codec'
/usr/bin/ld: libpdf-mupdf.so: hidden symbol `fz_opj_set_info_handler' isn't defined
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

@lemmi
lemmi merged commit 3700f1a into void-linux:master Aug 5, 2026
8 checks passed
@lemmi

lemmi commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks for taking care of this :)

@tornaria

tornaria commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

After this upgrade the print dialog doesn't show my (cups) printer anymore, only the "Print to pdf" choice shows up. Is this a known issue?

@lemmi

lemmi commented Aug 6, 2026

Copy link
Copy Markdown
Member

Works for me. Did you check using other programs?

@tornaria

tornaria commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Yes, the printer shows up in evince, but not in zathura. Downgrading to zathura-0.5.8_1 makes the printer show up again.

@dkwo
dkwo deleted the zathura2026 branch August 7, 2026 05:16
@dkwo

dkwo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@tornaria Any warnings or errors printed? At pwmt/zathura#936 possibly similar issues are mentioned.

@tornaria

tornaria commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@tornaria Any warnings or errors printed? At pwmt/zathura#936 possibly similar issues are mentioned.

Installing xdg-desktop-portal-gtk fixes the issue. I wonder if we should either (a) make it a dep of zathura (or gtk4) or (b) add an install message

The other programs I was trying are using gtk3 (evince, firefox).

@Andrew-Elia

Copy link
Copy Markdown

From my point of view adding an install message seems like the better option.

Not that much users use/need printers so making it a dependency for everyone may pull unneeded packages especially for those using tiling window managers and/or don't have the dependencies for xdg-desktop-portal-gtk already installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants