Skip to content

lightdm : add patch to use pam_limits - #62002

Open
AKArien wants to merge 1 commit into
void-linux:masterfrom
AKArien:master
Open

AKArien wants to merge 1 commit into
void-linux:masterfrom
AKArien:master

Conversation

@AKArien

@AKArien AKArien commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

I must admit i am not well versed with display managers or pam, but it is as far as i could understand « the » fix for limits not working properly when logging in with lightdm. After some looking up online, i found a few reddit threads ultimately linking back to this one sharing this fix.

As far as i could gather, this isn’t a problem of upstream because systemd does something that makes this unnecessary/instills the limits even without this ? And that it supports systemd first/only, hence the patch here rather than upstream.

@AKArien
AKArien marked this pull request as draft August 13, 2026 14:15
@AKArien
AKArien marked this pull request as ready for review August 14, 2026 17:05

@Duncaen Duncaen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why two patches?

@AKArien

AKArien commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Why two patches?

i'm sorry, what do you mean by that ? which are the "two patches" ?

@Duncaen

Duncaen commented Sep 11, 2026

Copy link
Copy Markdown
Member

Why two patches?

i'm sorry, what do you mean by that ? which are the "two patches" ?

srcpkgs/lightdm/patches/pam-limits.patch

srcpkgs/lightdm/patches/pam-turnstile-elogind.patch

Both patch the same files, you even adjusted the second patch to still apply after the first patch. Neither of those patches are intended for upstream and combining them would make sense.

@AKArien

AKArien commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Why two patches?

i'm sorry, what do you mean by that ? which are the "two patches" ?

srcpkgs/lightdm/patches/pam-limits.patch

srcpkgs/lightdm/patches/pam-turnstile-elogind.patch

Both patch the same files, you even adjusted the second patch to still apply after the first patch. Neither of those patches are intended for upstream and combining them would make sense.

oh, sure, it made more sense in my mind to separate them, as they serve different purposes, but i'll do that later today. And i'll also restore the comment i'm only now seeing i've accidentally deleted, oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants