Skip to content

redis: update to 8.8.2 - #62508

Open
eholzbach wants to merge 1 commit into
void-linux:masterfrom
eholzbach:redis
Open

redis: update to 8.8.2#62508
eholzbach wants to merge 1 commit into
void-linux:masterfrom
eholzbach:redis

Conversation

@eholzbach

Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, X86_64-glibc

Comment thread srcpkgs/redis/template Outdated
Comment thread srcpkgs/redis/template Outdated
short_desc="Advanced key-value store"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="BSD-3-Clause"
license="AGPL-3.0-only"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its something like:

Suggested change
license="AGPL-3.0-only"
license="AGPL-3.0-only OR SSPL-1.0 OR custom:RSALv2"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't including SSPL move this package to nonfree?

@Duncaen Duncaen Sep 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as long as an opensource license still applies its fine. Not sure if there is any precedent for listing alternative licenses, but I personally think it makes sense to include them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make xlint pass? It fails with Uses the SSPL license, which is not packageable

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird didn't know there was a special case just for that license. The lint seems a bit overzealous, not even allowing SSPL in nonfree repos.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed SSPL from the options so xlint would exit 0. Redis offers 3 options and the problematic one is most likely of no interest to Void users. Leaving the conversation as unresolved until I hear otherwise.

Comment thread srcpkgs/redis/template Outdated
@eholzbach
eholzbach force-pushed the redis branch 4 times, most recently from 3f4a545 to e9d7bf9 Compare September 13, 2026 21:18
@eholzbach
eholzbach marked this pull request as ready for review September 14, 2026 01:03
Comment thread srcpkgs/redis/template Outdated
# https://github.com/redis/redis/blob/669b2a1316f5b35ecf964281b77c054ff28dc934/deps/Makefile#L143-L145
if [ "$CROSS_BUILD" ]; then
make_build_args+=" JEMALLOC_CONFIGURE_OPTS=--host=$XBPS_CROSS_TRIPLET"
fi

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move the special cases back down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants