Conversation
otolias
force-pushed
the
MEGAcmd-update
branch
from
September 15, 2026 16:42
a6e322b to
2992612
Compare
Duncaen
reviewed
Sep 20, 2026
Comment on lines
+26
to
+29
| case "$XBPS_TARGET_WORDSIZE" in | ||
| 32) makedepends+=" fuse3-devel" ;; | ||
| 64) makedepends+=" fuse-devel" ;; | ||
| esac |
Member
There was a problem hiding this comment.
Can't it both use the same fuse verison?
Duncaen
requested changes
Sep 20, 2026
| hostmakedepends="pkg-config" | ||
| makedepends="libsodium-devel openssl-devel sqlite-devel libcurl-devel icu-devel | ||
| freeimage-devel libuv-devel readline-devel pcre-devel crypto++-devel | ||
| libmediainfo-devel ffmpeg-devel zlib-devel gtest-devel" |
Member
There was a problem hiding this comment.
Please indent with a single space inside of variables.
| revision=1 | ||
| _sdk_commit="fae76a36d60484657fbdf442b7b917ccc4fbad77" | ||
| build_style=cmake | ||
| configure_args="-DCMAKE_INSTALL_PREFIX=/ -DCMAKE_BUILD_TYPE=RelWithDebInfo -DVCPKG_ROOT='' |
Member
There was a problem hiding this comment.
Remove the -DCMAKE* variables, the cmake build style sets the prefix already and the build type is set to none in the build style so it will use the xbps-src defined cflags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Package hasn't been updated in a while, and the project has migrated from autotools to cmake during this time. Also, the template doesn't use the repo's MEGAsdk as a dependency, because it is vendored as a git subproject which is some releases out-of-sync. I plan to update MEGAsdk in a separate PR. I tested it briefly and it works, but further testing would be appreciated.