Apply top-level limit in VortexSource#8765
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
added
changelog/chore
robert3005
requested changes
Jul 15, 2026
robert3005
left a comment
robert3005
left a comment
Contributor
There was a problem hiding this comment.
Can we do this at the scan level so it applies everywhere?
Contributor
Author
|
I've tried in the past and complexity just shot up, I don't remember what my exact conclusion was but I think that it basically required some bigger changes and I always punted it because some bigger rewrite was around the corner. |
Contributor
Author
|
I have at least 4 closed PRs around this 😅 but looking back #7565 isn't that big, I'll try and revive it. |
Contributor
|
I am asking because we need it in python as well and I don’t think it should be that hard anymore or maybe we need to try a bit harder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Applies the query provided limit into the stream returned by
VortexSource.