fix: stream ndjson imports, remove per-line size limit - #342
Open
robc-vulncheck wants to merge 1 commit into
Open
robc-vulncheck wants to merge 1 commit into
robc-vulncheck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the bufio.Scanner with bufio.Reader.ReadBytes and flushes batches. No record size can now truncate or fail an index import.
Why?
The scanner was capped at 4MB and osv's largest record is ~19MB. ReadBytes grows to fit the record, so there is no ceiling to raise again.
Notes/Testing
Inserts into the DB are still controlled. There is a 25MB flush size and a max document size of 1GB (these are existing limits and unchanged). Tested locally by syncing ~30GB of data to offline db.
Blank lines are now skipped rather than raising errors.
Adds three cases to import_test.go
go test ./... green, vet and gofmt clean