Skip to content

Proposal: SecurityInfo in WebRequest - #899

Open
vkrot-cell wants to merge 5 commits into
w3c:mainfrom
vkrot-cell:security_info_web_request
Open

vkrot-cell wants to merge 5 commits into
w3c:mainfrom
vkrot-cell:security_info_web_request

Conversation

@vkrot-cell

Copy link
Copy Markdown

The proposal following discussion at #882

philwo pushed a commit to philwo/chromium that referenced this pull request Nov 6, 2025
This change allows to get ssl_info in TrustedHeaderClient, which is used
by url_loader and web_socket. The change won't impact performance of
url_loader or web_socket, that does not use trusted_headers_client,
which is only used in two places, and this is where ssl_info is needed
for extensions api in future:

extensions/browser/api/web_request/web_request_proxying_websocket.cc
extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

Extensions proposal: w3c/webextensions#899
Isolated Web App API proposal:
explainers-by-googlers/security-info-web-request#1

I have added low coverage reason because websocket.cc is not tested via
unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
out of scope of my CL to investigate why unit tests are absent for
websocket.cc.

Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
Bug: 458045659
Low-Coverage-Reason: HARD_TO_TEST
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Andrew Rayskiy <greengrape@google.com>
Commit-Queue: Vlad Krot <vkrot@google.com>
Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Nov 14, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
@vkrot-cell

Copy link
Copy Markdown
Author

@Rob--W Hi, any comments on the proposal?

aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 19, 2025
The change parses SecurityInfo object according to specification:
w3c/webextensions#899

@devlin has given approval to start working on this feature before the
spec is finalized.

Fixed: 460072357
Change-Id: I160c4b61c0d2da46eab10fae4e0794c7f692d26f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7167074
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Dominic Battre <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1547169}
@Rob--W

Rob--W commented Nov 19, 2025

Copy link
Copy Markdown
Member

@Rob--W Hi, any comments on the proposal?

I'm still in Japan following TPAC last week. I also have not had the chance to query for API usage (which I mentioned in https://github.com/w3c/webextensions/blob/main/_minutes/2025-11-06-wecg.md ), but that does not have to block my review.

The most important part is to verify that similar names and properties have equivalent meanings across browsers. I am not available until mid December, but if this is really pressing I can ask another team member to assist in the verification (or do that myself when idle). On what timeframe do you need feedback?

@vkrot-cell

Copy link
Copy Markdown
Author

@Rob--W It is fine for me to wait a week or two.

AlexeyBarabash pushed a commit to brave/brave-core that referenced this pull request Nov 19, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Nov 26, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Nov 26, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Nov 28, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
aarongable pushed a commit to chromium/chromium that referenced this pull request Nov 28, 2025
This CL adds main logic for intercepting TLS certificate info in Web
Request. @devlin has given his approval to start implementation while
the proposal is still not approved. The feature is behind feature flag.

The presubmit.py was modified to allow --ignore-certificate-errors in
tests. The flag is necessary because tests need to check code path with
expired certificate. The flag
network::switches::kIgnoreCertificateErrorsSPKIList does not work for
this case, because it treats invalid cert as valid, producing
state="secure".

Proposal: w3c/webextensions#899

Regarding low coverage reason, the mentioned files are tested via api
test currently
chrome/browser/extensions/api/web_request/web_request_apitest.cc and I
consider it out of scope of my CL to introduce unit tests from 0 to
existing files.

Low-Coverage-Reason: HARD_TO_TEST
Bug: 458045659
Change-Id: I29af4f38591457fb1e09c641b6385c5b7c6e8f7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7166297
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Tim <tjudkins@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1551464}
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 4, 2025
This CL adds logic to proxy web socket to obtain ssl info from there.

This follows previous CL -
https://chromium-review.googlesource.com/c/chromium/src/+/7166297/1

Proposal: w3c/webextensions#899
Bug: 458045659
Change-Id: Id0773cee906ee5c145faae642b5de71f40e087f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7165511
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Vlad Krot <vkrot@google.com>
Cr-Commit-Position: refs/heads/main@{#1553911}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 4, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 7, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
@vkrot-cell

Copy link
Copy Markdown
Author

Hi @Rob--W
Can you take a look this week?

@Rob--W

Rob--W commented Dec 8, 2025

Copy link
Copy Markdown
Member

Hi @Rob--W
Can you take a look this week?

I'll try to do so, yes. I wrote "mid December" before to have a bit of buffer, but I actually put this issue on my todo list for this week.

cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 10, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 11, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 12, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
emerick pushed a commit to brave/brave-core that referenced this pull request Dec 12, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 15, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}

@Rob--W Rob--W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience; this feedback took longer than expected because I wanted to complete the API usage analysis first (shared in the issue at #882 (comment)).

Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
Comment thread proposals/security_info_web_request.md Resolved
@OV-ETN

OV-ETN commented Dec 18, 2025

Copy link
Copy Markdown

thanks for this

emerick pushed a commit to brave/brave-core that referenced this pull request Dec 19, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
cdesouza-chromium added a commit to brave/brave-core that referenced this pull request Dec 21, 2025
This affects the override we have, however there is no use for this
argument in our use-case.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/c62fa5cbaa4542755128cda06cfd1ea813e41103

commit c62fa5cbaa4542755128cda06cfd1ea813e41103
Author: Vlad Krot <vkrot@google.com>
Date:   Thu Nov 6 03:07:35 2025 -0800

    Add ssl info to TrustedHeaderClient

    This change allows to get ssl_info in TrustedHeaderClient, which is used
    by url_loader and web_socket. The change won't impact performance of
    url_loader or web_socket, that does not use trusted_headers_client,
    which is only used in two places, and this is where ssl_info is needed
    for extensions api in future:

    extensions/browser/api/web_request/web_request_proxying_websocket.cc
    extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc

    Extensions proposal: w3c/webextensions#899
    Isolated Web App API proposal:
    explainers-by-googlers/security-info-web-request#1

    I have added low coverage reason because websocket.cc is not tested via
    unit tests, but with chrome/browser/net/websocket_browsertest.cc. It is
    out of scope of my CL to investigate why unit tests are absent for
    websocket.cc.

    Change-Id: I40f0fcb40db7a5efeaaf18276d6cc9bf6c7b48e3
    Bug: 458045659
    Low-Coverage-Reason: HARD_TO_TEST
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7106780
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Andrew Rayskiy <greengrape@google.com>
    Commit-Queue: Vlad Krot <vkrot@google.com>
    Cr-Commit-Position: refs/heads/main@{#1541131}
@vkrot-cell
vkrot-cell requested a review from Rob--W January 5, 2026 13:57
@carlosjeurissen carlosjeurissen added the topic: webRequest Issues related to observing and modifying network requests using the webRequest API. label May 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: webRequest Issues related to observing and modifying network requests using the webRequest API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants