Repository navigation
Conversation
FRSpecificTimeExpressionParser built the end of "22h00 - 02h00" on the start's day, so the range ended before it began. Move the end to the next day when it is earlier than the start, as the shared time expression parser does.
|
coverage: 93.133% (+0.001%) from 93.132% — youdie006:fix/fr-overnight-range into wanasit:master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #668. A French overnight range written with
hends before it starts:22h à 2h,22h - 2handde 22h à 2hdo the same on every date.22:00 - 02:00goes through the sharedAbstractTimeExpressionParserand already ends on the 16th.FRSpecificTimeExpressionParserbuilds the end from a clone of the start and has no next-day roll; this adds the sameaddDurationAsImplied({ day: 1 })the shared parser uses, when the end is earlier than the start and its day is not certain.The two new cases next to
13h-15hintest/fr/fr_time_exp.test.ts(one on a month's last day) fail on master; always adding a day fails13h-15h, and adding two days fails the new cases.npm run test(753 tests),prettier --check src testandnpm run buildpass.Written with AI assistance (Claude); I have reviewed the change.