Repository navigation
fix: use the reference timezone for "this month" and year-less dates - #670
Open
andrewstellman wants to merge 1 commit into
Open
andrewstellman wants to merge 1 commit into
andrewstellman wants to merge 1 commit into
Conversation
With a reference timezone that differs from the process timezone, "this
week/month/year", "last night" and dates without a year ("Feb 15",
"15 Feb", "2/15", "February") used the process calendar. "today" and
"next month" already used the reference timezone's calendar.
andrewstellman
marked this pull request as ready for review
October 10, 2026 23:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a reference timezone that differs from the process timezone, "this week/month/year", "last night" and dates without a year ("Feb 15", "15 Feb", "2/15", "February") use the process timezone's calendar. "today" and "next month" already use the reference timezone's.
These parsers read the reference instant directly. The change makes them call
context.reference.getDateWithAdjustedTimezone(), asENWeekdayParserandENEndOfCurrentMonthParseralready do.Only references with a
timezonethat differs from the process timezone get different results. A plainDatereference behaves as before.SlashDateFormatParseris shared, so other locales that use it are affected too. I added a test for English only.The new test in
test/en/en_relative.test.tsfails before the change and passes after it. The full suite passes (754 tests).Found by Quality Playbook, an AI code-review tool, with Claude; I reviewed the change.