Repository navigation
fix(de): revive #442 — relative units, ordinals, ago/later - #673
Open
Tzahreddin wants to merge 2 commits into
Open
Tzahreddin wants to merge 2 commits into
Tzahreddin wants to merge 2 commits into
Conversation
Port Georg Duffner's Enhance-de work onto current master APIs: - fix vorletzte/übernächste (was misparsed as letzte/nächste) - suffix modifiers früher/später; richer NUMBER_PATTERN (halb/viertel/paar) - ordinal day names for little-endian months; day abbr d/tg, std. - add de_time_units_ago/later tests; drop commented nested/strict blocks per review Addresses review notes on wanasit#442. Note: This commit message and the accompanying PR were written with AI assistance. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
This was referenced Oct 13, 2026
Open
Note: This commit message was written with AI assistance. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revival of @georgd’s work in #442 (Enhance de), rebased conceptually onto current
masterAPIs (reverseDuration, no dayjs).vorletzte/übernächste(previously misparsed asletzte/nächstevia barevor+ leftover stem)NUMBER_PATTERN(halb / viertel / dreiviertel / ein paar)am dritten Oktober)d/tg,std.de_time_units_ago/de_time_units_latertestsRelated
Test plan
npm test -- --testPathPattern='test/de/'(32 tests)Disclosure: This pull request (title, description, and code changes in this contribution) was created and written with AI assistance.
Made with Cursor