Repository navigation
Conversation
Rollup-based bundlers (e.g. Vite production builds) do not resolve the "./*" exports pattern for "chrono-node/en", so importing the English-only locale fails to build without an explicit entry. Add an explicit "./en" export so consumers can import just the English locale (smaller bundle) from bundlers that only support explicit subpath entries. Verified: a Vite 6 production build importing "chrono-node/en" fails to resolve before this change and succeeds after.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rollup-based bundlers (e.g. Vite 6 production builds) do not resolve the "./*" exports pattern for "chrono-node/en":
Node's own resolver handles the pattern fine, so this only surfaces in bundler builds. Today the workaround is a pnpm patch that adds an explicit exports entry.
Fix
Add an explicit "./en" export pointing at the existing built files. No other changes.
Verified with a minimal Vite 6 app build: fails before, passes after.
Happy to add explicit entries for the other locales as well if you'd prefer a complete set.