Repository navigation
Conversation
The zh.hant date parser only accepted one or two Chinese numerals for the day, so days such as 二十四 or 三十一 were cut short: "十月二十四日" was read as October 20 and "十二月三十一號" as December 30. Allow up to three numerals, as the zh.hans parser already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zh.hant date parser only allows one or two Chinese numerals for the day, so any day written with three characters gets cut off:
十月二十四日→ Oct 20 (expected Oct 24)十二月三十一號→ Dec 30 (expected Dec 31)Because the match stops early, a following time also doesn't merge:
十月二十四日下午三點comes back as two separate results.zh.hans already allows up to three numerals here and parses these correctly, so this change makes the zh.hant day group match it (
{1,2}→{1,3}). The month group stays as is since months never need three characters.Added a test to
zh_hant_date.test.tscovering both examples; it fails on master and passes with this change. The full test suite passes.I used Claude Code to write this change.