Skip to content

fix(parsers): accept ISO 8601 fractional seconds longer than 4 digits #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyberNativeAI wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −2
Open

fix(parsers): accept ISO 8601 fractional seconds longer than 4 digits #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/common/parsers/ISOFormatParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const PATTERN = new RegExp(
"(?:T" + //..
"([0-9]{1,2}):([0-9]{1,2})" + // hh:mm
"(?:" +
":([0-9]{1,2})(?:\\.(\\d{1,4}))?" +
":([0-9]{1,2})(?:\\.(\\d+))?" +
")?" + // :ss.s
"(" +
"Z|([+-]\\d{2}):?(\\d{2})?" +
Expand Down Expand Up @@ -57,7 +57,7 @@ export default class ISOFormatParser extends AbstractParserWithWordBoundaryCheck
}

if (match[MILLISECOND_NUMBER_GROUP] != null) {
components.assign("millisecond", parseInt(match[MILLISECOND_NUMBER_GROUP]));
components.assign("millisecond", parseInt(match[MILLISECOND_NUMBER_GROUP].padEnd(3, "0").slice(0, 3)));
}
if (match[TZD_GROUP] != null) {
// The Zulu time zone (Z) is equivalent to UTC
Expand Down
30 changes: 30 additions & 0 deletions test/en/en_inter_std.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,33 @@ test("Test - Single Expression with local timezeon", function () {
expect(result.start).toBeDate(new Date("2015-07-31T12:00:00"));
});
});

test("Test - ISO 8601 with 6 fractional-second digits and a positive offset", function () {
testSingleCase(chrono, "2024-03-10T10:00:00.123456+05:30", new Date(2012, 7, 8), (result) => {
expect(result.text).toBe("2024-03-10T10:00:00.123456+05:30");
expect(result.start.get("second")).toBe(0);
expect(result.start.get("millisecond")).toBe(123);
expect(result.start.isCertain("timezoneOffset")).toBe(true);
expect(result.start).toBeDate(new Date("2024-03-10T04:30:00.123Z"));
});
});

test("Test - ISO 8601 with 5 fractional-second digits and a negative offset", function () {
testSingleCase(chrono, "2024-03-10T10:00:00.12345-05:00", new Date(2012, 7, 8), (result) => {
expect(result.text).toBe("2024-03-10T10:00:00.12345-05:00");
expect(result.start.get("second")).toBe(0);
expect(result.start.get("millisecond")).toBe(123);
expect(result.start.isCertain("timezoneOffset")).toBe(true);
expect(result.start).toBeDate(new Date("2024-03-10T15:00:00.123Z"));
});
});

test("Test - ISO 8601 with 9 fractional-second digits and Z", function () {
testSingleCase(chrono, "2024-03-10T10:00:00.123456789Z", new Date(2012, 7, 8), (result) => {
expect(result.text).toBe("2024-03-10T10:00:00.123456789Z");
expect(result.start.get("second")).toBe(0);
expect(result.start.get("millisecond")).toBe(123);
expect(result.start.isCertain("timezoneOffset")).toBe(true);
expect(result.start).toBeDate(new Date("2024-03-10T10:00:00.123Z"));
});
});