Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request centralizes NuGet package metadata and asset references by moving common properties to the root Directory.Build.props file and updating file paths to use the $(RepoRoot) property for consistency.
- Moved
PackageIconandPackageReadmeFileproperties from individual project Directory.Build.props files to the root level - Updated README.md file references to use absolute paths with
$(RepoRoot)instead of relative paths - Removed redundant package metadata properties from Federation, Identity, and Security project configurations
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Directory.Build.props | Added centralized package metadata properties for src projects |
| Federation/Directory.Build.props | Removed redundant package properties and updated README path |
| Identity/Directory.Build.props | Removed redundant package properties and updated README path |
| Security/Directory.Build.props | Removed redundant package properties and updated README path |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how NuGet package metadata and assets (such as icons and README files) are included for the
Federation,Identity, andSecurityprojects. The main goal is to centralize and standardize the way these files are referenced and packaged, improving maintainability and consistency across the projects.Centralization and Standardization of Package Metadata and Assets:
<PackageIcon>and<PackageReadmeFile>properties from individual project-levelDirectory.Build.propsfiles to the rootDirectory.Build.props, ensuring consistent package metadata for all projects undersrc. [1] [2] [3] [4]README.mdand logo files) in all affected projects to use the$(RepoRoot)property, ensuring correct file paths and reducing duplication or errors from relative paths. [1] [2] [3] [4]Directory.Build.propsfiles, as these are now handled centrally. [1] [2] [3]These changes streamline the packaging process and make it easier to maintain consistent NuGet package metadata and assets across multiple projects.