Skip to content

feat: update README.md paths and clean up Directory.Build.props - #3

Merged
wangkanai merged 3 commits into
mainfrom
readme
Aug 30, 2025
Merged

feat: update README.md paths and clean up Directory.Build.props#3
wangkanai merged 3 commits into
mainfrom
readme

Conversation

@wangkanai

Copy link
Copy Markdown
Owner

This pull request refactors how NuGet package metadata and assets (such as icons and README files) are included for the Federation, Identity, and Security projects. The main goal is to centralize and standardize the way these files are referenced and packaged, improving maintainability and consistency across the projects.

Centralization and Standardization of Package Metadata and Assets:

  • Moved the <PackageIcon> and <PackageReadmeFile> properties from individual project-level Directory.Build.props files to the root Directory.Build.props, ensuring consistent package metadata for all projects under src. [1] [2] [3] [4]
  • Updated asset inclusion (README.md and logo files) in all affected projects to use the $(RepoRoot) property, ensuring correct file paths and reducing duplication or errors from relative paths. [1] [2] [3] [4]
  • Removed redundant or now-unnecessary property and item group definitions from the individual project Directory.Build.props files, as these are now handled centrally. [1] [2] [3]

These changes streamline the packaging process and make it easier to maintain consistent NuGet package metadata and assets across multiple projects.

@wangkanai wangkanai added this to the 3.0.0 milestone Aug 30, 2025
@wangkanai wangkanai self-assigned this Aug 30, 2025
Copilot AI review requested due to automatic review settings August 30, 2025 14:09
@wangkanai wangkanai added the documentation Improvements or additions to documentation label Aug 30, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request centralizes NuGet package metadata and asset references by moving common properties to the root Directory.Build.props file and updating file paths to use the $(RepoRoot) property for consistency.

  • Moved PackageIcon and PackageReadmeFile properties from individual project Directory.Build.props files to the root level
  • Updated README.md file references to use absolute paths with $(RepoRoot) instead of relative paths
  • Removed redundant package metadata properties from Federation, Identity, and Security project configurations

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
Directory.Build.props Added centralized package metadata properties for src projects
Federation/Directory.Build.props Removed redundant package properties and updated README path
Identity/Directory.Build.props Removed redundant package properties and updated README path
Security/Directory.Build.props Removed redundant package properties and updated README path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Security/Directory.Build.props
Comment thread Identity/Directory.Build.props Outdated
Comment thread Federation/Directory.Build.props Outdated
@wangkanai wangkanai moved this to In Progress in Federation Aug 30, 2025
wangkanai and others added 2 commits August 30, 2025 21:32
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wangkanai
wangkanai merged commit 2fc164a into main Aug 30, 2025
1 check passed
@wangkanai
wangkanai deleted the readme branch August 30, 2025 14:37
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Federation Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants