Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the Directory.Build.targets file to provide standardized build configurations for benchmark and test projects. The changes automatically configure projects based on their naming conventions to ensure consistent settings across the codebase.
- Adds automated configuration for benchmark projects (optimization, executable output, SonarQube exclusion)
- Introduces standardized test project settings with xUnit integration and test host dependencies
- Updates test configuration file handling from linked
testconfig.jsonto localxunit.runner.json
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Directory.Build.targetsfile to improve the build configuration for benchmark and test projects. The main changes add specific settings and dependencies for projects whose names contain "Benchmark" or "Tests", making it easier to manage benchmarks and tests consistently.Benchmark project configuration:
OutputTypetoExe, enable optimizations, disable packing, and exclude from SonarQube analysis for projects with "Benchmark" in their name.BenchmarkDotNetpackage reference for benchmark projects.Test project configuration:
OutputTypetoExeand disable packing for test projects.Usingdirective forXunitin test projects.xunit.runner.json(instead of a linkedtestconfig.json) and copy it to the output directory.Microsoft.TestPlatform.TestHostpackage reference for test projects.