Repository navigation
ci: pin contract lint to the blank-line fix (#164) - #133
Merged
Merged
Conversation
The pinned revision ended a job block at the first blank line inside it, so every rule violation after that point was invisible. This repo is clean under the fixed lint, so nothing changes here; the pin move just stops the lint from under-reporting in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
contract-lintpin to the revision that stops treating a blank lineas a job boundary — wazootech/workspace-cli#164, closing
wazootech/workspace-cli#163.
The pinned revision (
9841b8de) ended a job block at the first blank line insideit, and blank lines are ordinary inside
run: |bodies, so every rule violationafter that point was invisible.
Verification
This repo is clean under the fixed lint, so the pin move changes no finding here:
Merge order
Independent of the other consumers.
wazoo-consoleis the one repo that is notclean under the fixed lint (3 findings), so its pin has to ride with
wazootech/wazoo-console#113 rather than move on its own.