Repository navigation
ci: read CLOUDFLARE_API_TOKEN from vault folder /ci (DO NOT MERGE until vault copied) - #135
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CONTRIBUTING still said to keep CLOUDFLARE_API_TOKEN in GitHub secrets, which contradicts the deploy jobs and the zero-GitHub-secrets contract. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until the owner has copied
CLOUDFLARE_API_TOKENinto vault folder/ciin BOTH theqaandprodenvironments.deploy-qaruns automatically on push tomain; merging early breaks QA deploys.What changes
Adds
secret-path: /cito the two Infisical fetch steps whosesecret-nameisCLOUDFLARE_API_TOKENin.github/workflows/ci.yml:deploy-qa("Fetch Cloudflare deploy token from Infisical (qa)")deploy-prod("Fetch Cloudflare deploy token from Infisical (prod)")Unchanged: the
WORLDS_API_ADMIN_KEYfetch (health-qa) and the one insmoke-qa.yml.secret-registry.mdis updated to record that the deploy credential lives at vault folder/ci, outside any sync's scope. Names only; no values.secret-pathis a documented input ofInfisical/secrets-action@v1.0.17(action.yaml), used together withsecret-name. Contract lint: 0 violations (it does not constrainsecret-path).Verification and gaps
deploy-qaexercises the new path on merge tomain.deploy-prodonly on the next manual dispatch; the prod path is unobserved until then./ciholds the token in either environment), or any live deploy.Not part of this PR (follow-ups)
CONTRIBUTING.mdline 115 still says to keep the token in GitHub secrets; left untouched here.🤖 Generated with Claude Code