Repository navigation
[autopilot] skills: clarify concurrent extension settings writes - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that re-reading settings immediately before writing narrows a stale-snapshot window but does not make a storage read–merge–write atomic. Explain how to serialize the whole sequence through one owner and test the remaining race with a controlled interleaving.
Motivating pattern: a background worker and popup both save a shared settings object; a delayed whole-object write can overwrite an independent preference change. Awaiting the write proves completion, while synchronous mocks and concurrent saves placed before the fresh read can hide the lost update. Readers gain a precise boundary for the existing example and a regression-test recipe.
Validation: all 67 unittest tests pass; skill validator passes; git diff --check passes. Only the existing browser-extension skill changes.