Repository navigation
[autopilot] skills: await extension event listeners directly in tests - #180
Merged
Merged
Conversation
…et mock event triggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a short trap to the MV3 extension skill's mock section: hand-rolled event-trigger helpers call listeners synchronously and discard their promises, so assertions race the handler's async work. Recommends awaiting the registered listener directly, and notes that fake timers also fake setImmediate. Motivated by a recurring pattern of tests that looked deterministic but only passed on microtask timing. Small, scoped to one skill; no registration changes.