Fix decoding of long lists (payload >= 56 bytes) - #30
Merged
Merged
Conversation
The 0xf8-0xff branch sliced the list payload with $totalLength instead of $length, reading $llength bytes past the end of the list, and computed the remainder from $length instead of $totalLength. Any long list followed by a sibling item was decoded incorrectly. Add hand-built encode/decode vectors for long lists with siblings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- actions/cache v2 -> v4 (v2 is now rejected by GitHub) - actions/checkout v2 -> v4 - codecov/codecov-action v1 -> v5 - Include the PHP version in the cache key and hash composer.json instead of the gitignored composer.lock, so matrix jobs no longer share one vendor/ directory across PHP versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
============================================
+ Coverage 64.23% 74.17% +9.93%
Complexity 55 55
============================================
Files 3 3
Lines 151 151
============================================
+ Hits 97 112 +15
+ Misses 54 39 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0xf8-0xff branch sliced the list payload with $totalLength instead of $length, reading $llength bytes past the end of the list, and computed the remainder from $length instead of $totalLength. Any long list followed by a sibling item was decoded incorrectly.
Add hand-built encode/decode vectors for long lists with siblings.