Keep leading zero bytes when encoding hex strings - #34
Merged
Merged
Conversation
Str::encode(..., 'hex') stripped leading zeros from hex input longer than one byte (added in web3p#26 for ethereum-tx quantities). Hex strings are byte strings, so this corrupted fixed-width values such as addresses and hashes: 0x0000...0001 (20 bytes) encoded as 01, which geth rejects (web3p#27). Encode hex strings byte-for-byte, as ethers.js does. Odd-length input is still padded to a whole byte. BREAKING CHANGE: integer quantities passed as hex with leading zeros (e.g. "0x00cb9d") are no longer trimmed; callers must strip leading zeros from quantities themselves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
============================================
- Coverage 94.44% 94.37% -0.07%
+ Complexity 61 60 -1
============================================
Files 3 3
Lines 162 160 -2
============================================
- Hits 153 151 -2
Misses 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Str::encode(..., 'hex') stripped leading zeros from hex input longer than one byte (added in #26 for ethereum-tx quantities). Hex strings are byte strings, so this corrupted fixed-width values such as addresses and hashes: 0x0000...0001 (20 bytes) encoded as 01, which geth rejects (#27).
Encode hex strings byte-for-byte, as ethers.js does. Odd-length input is still padded to a whole byte.
BREAKING CHANGE: integer quantities passed as hex with leading zeros (e.g. "0x00cb9d") are no longer trimmed; callers must strip leading zeros from quantities themselves.