Reject non-canonical lengths when decoding - #36
Merged
Merged
Conversation
The decoder accepted long-form prefixes (0xb8-0xbf, 0xf8-0xff) for lengths below 56 (e.g. b80161, f80180) and lengths with a leading zero byte (e.g. b90038...), except for an exact "00". geth rejects these as non-canonical. A long string declaring a length beyond PHP_INT_MAX also crashed with a TypeError instead of a RuntimeException. Reject both non-canonical forms in the long string and long list branches, and check the declared long string size before slicing. Re-enable testInvalidRlp so it decodes invalidrlptest.json and expects an exception, and add canonical and non-canonical boundary vectors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
============================================
+ Coverage 94.44% 96.55% +2.10%
- Complexity 61 68 +7
============================================
Files 3 3
Lines 162 174 +12
============================================
+ Hits 153 168 +15
+ Misses 9 6 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decoder accepted long-form prefixes (0xb8-0xbf, 0xf8-0xff) for lengths below 56 (e.g. b80161, f80180) and lengths with a leading zero byte (e.g. b90038...), except for an exact "00". geth rejects these as non-canonical. A long string declaring a length beyond PHP_INT_MAX also crashed with a TypeError instead of a RuntimeException.
Reject both non-canonical forms in the long string and long list branches, and check the declared long string size before slicing.
Re-enable testInvalidRlp so it decodes invalidrlptest.json and expects an exception, and add canonical and non-canonical boundary vectors.