Skip to content

<image> and <credit-image> write valign="top" for other alignments #444

Description

@webern

Images use the valign-image type (core::ValignImage, default top), not valign.
setAttributesFromPositionData (src/private/mx/impl/PositionFunctions.h:176-184) first calls the
presence setter, which sets a default ValignImage{}
(src/private/mx/utility/OptionalMembers.h:100-120). It then calls the value setter, which is
compiled out because a core::Valign does not convert (OptionalMembers.h:163-177).

  • <credit-image> (PageTextFunctions.cpp:67) writes valign="top" for any authored vertical
    alignment. The reader never sets one (PageTextFunctions.cpp:43-47), so round-trips do not show
    this.
  • Direction <image> (DirectionWriter.cpp:1011-1029) corrects top, middle and bottom afterwards,
    but baseline still writes top, although the comment there says it is not written.

Found while auditing silent recoveries for #432 (#439).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    aiIssues opened by, or through, a coding agent.bugsoftware defectimplAffects the mx::impl layernon-breakingfixes or implementation that do not require breaking changes

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions