Skip to content

Fix #3659#3669

Closed
Astralcircle wants to merge 4 commits into
masterfrom
Astralcircle-patch-1
Closed

Fix #3659#3669
Astralcircle wants to merge 4 commits into
masterfrom
Astralcircle-patch-1

Conversation

@Astralcircle

@Astralcircle Astralcircle commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Adds rounding to numbers
Fixes #3659

Adds rounding to numbers
@CornerPin

Copy link
Copy Markdown
Contributor

Check if the rounded base is 10, otherwise this is gonna break chips that convert non-integers to their base-10 representation.

print(toString(_PI, 10)) # Will print 3

@Astralcircle

Astralcircle commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Check if the rounded base is 10, otherwise this is gonna break chips that convert non-integers to their base-10 representation.

print(toString(_PI, 10)) # Will print 3

Doesn't it already does that at line 588? (if base == 10 then return tostring(number) end)
Oh ok

@Astralcircle

Copy link
Copy Markdown
Contributor Author

Something happened on github side and i can't merge it, i'll recreate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toString(number, 16) crashes e2

2 participants