Repository navigation
fix(recipes): use valid trigger and action names - #8
Closed
am-official wants to merge 1 commit into
Closed
am-official wants to merge 1 commit into
am-official wants to merge 1 commit into
Conversation
charging_notify used POWER_CONNECTED and night_dnd / work_wifi_silent used SET_RINGER. Neither exists in TriggerType / ActionType, so importing these recipes failed. They now use CHARGER_CONNECTED and RINGER_MODE.
Owner
|
Fixed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7. Three recipes used names that don't exist in
TriggerType/ActionType, so importing them failed:charging_notify.json: triggerPOWER_CONNECTED→CHARGER_CONNECTEDnight_dnd.json: actionSET_RINGER→RINGER_MODEwork_wifi_silent.json: actionSET_RINGER→RINGER_MODENothing else changes. I checked every file in
recipes/against the enums inModels.kt(trigger, condition, action type and ringer mode), and all 8 now resolve.Target
beta(default)main(stable hotfix only)Checklist