Skip to content

Update to IDF 5.5.4 - #5769

Merged
softhack007 merged 6 commits into
wled:mainfrom
netmindz:idf_5-5-4
Aug 10, 2026
Merged

Update to IDF 5.5.4#5769
softhack007 merged 6 commits into
wled:mainfrom
netmindz:idf_5-5-4

Conversation

@netmindz

@netmindz netmindz commented Aug 5, 2026

Copy link
Copy Markdown
Member

Not tested with hardware yet, but this gets the build to pass

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with the latest ESP32 software platform and toolchain.
    • Updated support for newer Arduino Core and ESP-IDF releases.
    • Improved ESP32-C5 compatibility with the shared platform configuration.
    • Restored normal NTP configuration behavior on ESP32-C5 devices.
    • Prevented build conflicts involving SHA1 support and time-related type definitions.
    • Improved ESP32 CPU revision reporting on newer firmware platforms.
    • Updated the minimum supported PlatformIO version for more reliable builds.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The PR updates ESP32 IDF V5 platform versions and settings, raises the PlatformIO requirement, removes ESP32-C5 NTP overrides, and adjusts SHA1, time_t, and chip-revision compatibility logic.

Changes

ESP32 IDF V5 compatibility

Layer / File(s) Summary
ESP32 IDF V5 platform update
platformio.ini, requirements.in, requirements.txt, wled00/cfg.cpp, wled00/set.cpp
The platform uses Tasmota 2026.05.50, shared pioarduino settings, and the __unreachable compatibility definition. ESP32-C5 uses the shared platform settings. ESP32-C5-specific NTP overrides were removed. PlatformIO now requires version 6.1.19.
Library compatibility guards
wled00/mbedtls_sha1_shim.cpp, wled00/src/dependencies/time/TimeLib.h
The SHA1 shim checks MBEDTLS_SHA1_C. The fallback time_t definition also checks _TIME_T_DECLARED.
ESP32 revision diagnostics
wled00/wled.cpp
ESP32 setup logging uses the IDF 5+ major.minor chip-revision format and retains the legacy format for older IDF versions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • wled/WLED#4838: Continues the ESP-IDF V5 migration with shared PlatformIO and compatibility updates.
  • wled/WLED#5048: Covers ESP32-C5/V5 platform and compatibility changes.
  • wled/WLED#5749: Updates related ESP32/ESP-IDF V5 platform settings.

Suggested labels: V5, Awaiting testing

Suggested reviewers: softhack007, dedehai

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: updating the project to ESP-IDF 5.5.4.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@softhack007 softhack007 self-assigned this Aug 6, 2026
@softhack007
softhack007 self-requested a review August 6, 2026 08:28

@DedeHai DedeHai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ESP32 classic, works.

@DedeHai

DedeHai commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

@softhack007 I got my C5. It works with latest tasmota and also enabling NTP gives me no crashes.

@netmindz

netmindz commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

Merge once you are happy please @softhack007

@softhack007

softhack007 commented Aug 8, 2026

Copy link
Copy Markdown
Member

Merge once you are happy please @softhack007

@netmindz I'll take a look on Sunday 👍

Edit: on Monday

Comment thread platformio.ini Outdated
@softhack007

Copy link
Copy Markdown
Member

E (852) MSPI Timing: Failed to allocate dummy cacheline for PSRAM memory barrier!

This seems to be a known "hickup" on -C5 with PSRAM espressif/arduino-esp32#12587

@softhack007

Copy link
Copy Markdown
Member

It works with latest tasmota and also enabling NTP gives me no crashes.

I can also cross-check this on my board. The -C5 crash was always kind of mysterious - maybe it was a consequence of another bug we already fixed in main 🤔

crash on NTP does not occur any more, C5 builds successfully with tasmota core.
@softhack007

Copy link
Copy Markdown
Member

It works with latest tasmota and also enabling NTP gives me no crashes.

I can also cross-check this on my board. The -C5 crash was always kind of mysterious - maybe it was a consequence of another bug we already fixed in main 🤔

@DedeHai both observations confirmed on my board (C5 devkit N8R4, chip revision v1.0, with PSRAM)

  • no more crashes on NTP receive
  • works with tasmota

espressif uses a new format in ESP.getChipRevision() now: revMajor*100 + revMinor
@softhack007

Copy link
Copy Markdown
Member

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@softhack007 softhack007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me now.
@DedeHai can you give it a quick spin on your boards? If nothing unexpected comes up, we should be good to merge.

@DedeHai

DedeHai commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

I am afk until next monday

@softhack007
softhack007 merged commit b6de555 into wled:main Aug 10, 2026
30 checks passed
@netmindz
netmindz deleted the idf_5-5-4 branch August 10, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants