Repository navigation
NE-1259 Enforce MTU correctness - #137
loulecrivain wants to merge 6 commits into
Conversation
|
currently on hold as draft implementation is not satisfactory |
276bfa9 to
db28202
Compare
|
1st draft PR ready for review and validation of general concept |
db28202 to
80cc5d4
Compare
80cc5d4 to
4e2b178
Compare
unfokus
left a comment
unfokus
left a comment
There was a problem hiding this comment.
First of all, good work! I like the modular implementation style, the refactoring of cosmo is really paying off.
There are some small misunderstandings as for the logic/platform behavior, see my other comments about that. But I think that should be easy to fix. Message me if there are any doubts.
|
|
||
| class RouterL2VPNValidatorVisitor(AbstractL2VPNVisitor): | ||
| # 8021ad (vlan-bridge) and 8021q (vlan-ccc) encaps auto-sets phy MTU to correct MTU if logical MTU is not specified | ||
| MAX_DEFAULT_PHY_MTU = DEFAULT_LOGICAL_MTU + IEE80213_HDR_BYTES + IEE80213_HDR_BYTES |
There was a problem hiding this comment.
why 802.3 header (twice)?
Since this is a L2 Tunnel, the L2 header is part of the payload. So for L2 tunnels without VLAN encap/decap we don't need to account for any overhead, the physical MTU can be equal to the logical MTU. If a VLAN is added/removed, we only need to account for the VLAN header.
|
|
||
|
|
||
| class RouterL2VPNValidatorVisitor(AbstractL2VPNVisitor): | ||
| # 8021ad (vlan-bridge) and 8021q (vlan-ccc) encaps auto-sets phy MTU to correct MTU if logical MTU is not specified |
There was a problem hiding this comment.
I think this is the wrong way around.
The encap on the logical interface does not set the physical MTU. The physical MTU is handed down to the logical.
So if I set my physical MTU to 9000, the logical interface MTU is inherited from the physical.
When I set the logical MTU to 9000 but leave the physical unconfigured, the logicals is clamped by the physicals default (1514 or so).
So I think we should rather have the default logical interface MTU as a constant, as there is no such thing as a default logical interface MTU, and calculate the inherited logical interface MTU from the physicals MTU + encapsulation overhead.
(We can later implement that for L3 interfaces as well and clean up some of the hardcoded logic there!)
|
TODO: also implement checks for vlan terminated L2VPNs |
96c4626 to
8ddddd5
Compare
2 participants
No description provided.