Skip to content

Order detail: shipping label banner dismiss button announces the wrong accessibility label #16474

Closed

Description

@samiuelson

Describe the bug

The dismiss button on the "Need a shipping label?" banner in order detail has the wrong contentDescription. TalkBack announces it as "Waiting for refund confirmation…" instead of something like "Dismiss".

The layout points the button at a refund string:

https://github.com/woocommerce/woocommerce-android/blob/trunk/WooCommerce/src/main/res/layout/order_detail_install_wc_shipping_banner.xml#L57-L65

<ImageButton
    android:id="@+id/dismiss_shippingLabelBanner_button"
    style="@style/Woo.ImageButton.Close"
    ...
    android:contentDescription="@string/order_refunds_amount_refund_confirmation_message"

order_refunds_amount_refund_confirmation_message is "Waiting for refund confirmation…".

To Reproduce

  1. Open a store that does not have WooCommerce Shipping installed.
  2. Open any order that shows the "Need a shipping label?" banner.
  3. Turn on TalkBack, or dump the view hierarchy with uiautomator.
  4. Focus the X button in the banner's top-right corner.

Expected behavior

The button is announced as "Dismiss" (or "Close").

Actual behavior

The button is announced as "Waiting for refund confirmation…".

Environment

  • Reproduced on 25.4-rc-1, Android emulator (Pixel 9 Pro Fold, API 36).
  • Present on trunk.
  • Introduced in e7ff7b1 (2022-05-30), so it affects all releases since.

Suggested fix

Point the contentDescription at @string/dismiss (already exists in strings.xml), or add a dedicated string for this banner.

Activity

  1. dangermattic commented on Aug 26, 2026

    @dangermattic
    Collaborator

    🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions