Repository navigation
Conversation
|
burkestar
added a commit
to burkestar/emulate
that referenced
this pull request
Oct 6, 2026
burkestar
added a commit
to burkestar/emulate
that referenced
this pull request
Oct 6, 2026
Fork build carrying workos#130 and workos#132 until upstream releases them. The release-please manifest stays at 0.14.0 so upstream releases merge cleanly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
Problem
dsync.activatedanddsync.deletedevents reused the RESTDirectoryshape. Fordsync.activatedthat meant a singulardomainand nodomainsarray, so workos-python 10.5'sDsyncActivatedData.from_dictraised. That failed the wholeGET /eventspage.Changes
dsync.activated: replacesdomainwithdomains, an array of the organization's domains as{ object: 'organization_domain', id, domain }. Reportsstatewith the event-catalog names (linkedbecomesactive,unlinkedbecomesinactive).dsync.deleted: dropsdomainandexternal_key, which the spec doesn't include for this event, and reportsstate: 'deleting'.external_keywhen the config doesn't give one. The spec requires it as a string on both the Directory object and thedsync.activatedpayload./directoriesresponse shape is unchanged.Testing
seed-directories.spec.tscheck both payloads againstEVENT_DATA_REQUIREMENTS, thedomainscontents, and the unchanged REST shape.workos==10.5.0: before this change it raisesUnexpected API response while parsing DsyncActivatedData: 'domains'; with it the event parses asDsyncActivatedDatawith theacme.testdomain.Note for reviewers
domainslists all of the directory's organization's domains, not only the one matching the directory'sdomainfield. That's my reading of the docs' "domains array of Organization Domain". Happy to narrow it if production behaves differently.